refactor: fix some aggregation ops in the sqlglot compiler#2382
Merged
chelsea-lin merged 4 commits intomainfrom Jan 15, 2026
Merged
refactor: fix some aggregation ops in the sqlglot compiler#2382chelsea-lin merged 4 commits intomainfrom
chelsea-lin merged 4 commits intomainfrom
Conversation
product-auto-label
bot
added
size: m
shuoweil
approved these changes
Jan 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change fixes several aggregation-related test failures in #2248 by including the following operators:
agg_ops.DiffOp: Fixes test_date_series_diff_aggagg_ops.AllOp/AnyOp: Fixes test_list_apply_callableagg_ops.QuantileOp: Fixes test_dataframe_aggregates_medianagg_ops.ProductOp: Fixes test_dataframe_groupby_analyticFixes internal issue 417774347 🦕